Skip to content

Conversation

@dronefreak
Copy link
Collaborator

@dronefreak dronefreak commented Feb 4, 2026

Summary

In this PR we introduce github workflows, dependabot, PR templates etc.

Changes

  • Introduce CI.yml
  • Introduce PR Template
  • Introduce other useful YML files

Testing

  • Tests pass locally (python -m pytest tests/ -v)
  • Pre-commit hooks pass (pre-commit run --all-files)

Related Issues

Closes #2 and #3

Signed-off-by: dronefreak <kumaar324@gmail.com>
Signed-off-by: dronefreak <kumaar324@gmail.com>
@dronefreak dronefreak self-assigned this Feb 4, 2026
@dronefreak dronefreak linked an issue Feb 4, 2026 that may be closed by this pull request
Signed-off-by: dronefreak <kumaar324@gmail.com>
@dronefreak dronefreak added the enhancement New feature or request label Feb 4, 2026
@dronefreak dronefreak changed the title Feature/GitHub workflows feat: add GitHub workflows Feb 4, 2026
Signed-off-by: dronefreak <kumaar324@gmail.com>
@lfagotbouquet
Copy link
Owner

I enabled the dependency graph to fix the test that was failing.

I still need to review rapidly the files for the github workflows (I've only checked the minor modifications done for the other files).

…requirements-dev.txt

Signed-off-by: dronefreak <kumaar324@gmail.com>
…requirements-dev.txt

Signed-off-by: dronefreak <kumaar324@gmail.com>
@dronefreak
Copy link
Collaborator Author

@lfagotbouquet another point of interest that I had. Inside the ci.yml file I have added different OS to test the template project. For example:

      matrix:
        os: [ubuntu-latest, macos-latest]

However, when I try to add windows-latest there is a problem, with the subprocess lib inside the tests and the tests crash.

My question to you is, is it a good idea to consider changing to a different lib (other than subprocess) something which is compatible with windows-latest? Or is it fine in the current state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Github Workflows

2 participants